Skip to content

Support remaining collections in config binder generator#86285

Merged
layomia merged 3 commits into
dotnet:mainfrom
layomia:binder-gen-collections
May 16, 2023
Merged

Support remaining collections in config binder generator#86285
layomia merged 3 commits into
dotnet:mainfrom
layomia:binder-gen-collections

Conversation

@layomia

@layomia layomia commented May 15, 2023

Copy link
Copy Markdown
Contributor

Contributes to #79527.

@layomia layomia added this to the 8.0.0 milestone May 15, 2023
@layomia layomia self-assigned this May 15, 2023
@ghost

ghost commented May 15, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

Issue Details

Contributes to #79527.

Author: layomia
Assignees: layomia
Labels:

area-System.Text.Json

Milestone: 8.0.0

@ghost

ghost commented May 16, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-extensions-configuration
See info in area-owners.md if you want to be subscribed.

Issue Details

Contributes to #79527.

Author: layomia
Assignees: layomia
Labels:

area-System.Text.Json, area-Extensions-Configuration

Milestone: 8.0.0

Comment thread src/libraries/Microsoft.Extensions.Configuration.Binder/gen/KnownTypeSymbols.cs Outdated

@eiriktsarpalis eiriktsarpalis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall.

@layomia
layomia force-pushed the binder-gen-collections branch from a8dba61 to c4a3635 Compare May 16, 2023 18:37
@layomia
layomia force-pushed the binder-gen-collections branch from a50eb61 to ef2b75b Compare May 16, 2023 21:34
@layomia
layomia merged commit fd4c320 into dotnet:main May 16, 2023
@layomia
layomia deleted the binder-gen-collections branch May 16, 2023 23:20
@layomia layomia added the source-generator Indicates an issue with a source generator feature label May 17, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jun 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Extensions-Configuration source-generator Indicates an issue with a source generator feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants